From 69773763ee7fbd2c494a5b8c5ff13093715fb788 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Javier=20Jard=C3=B3n?= Date: Tue, 20 Oct 2009 04:08:00 +0200 Subject: [PATCH] Fix a compilation warning Reorder the function so the "lookup_context" variable can't be used uninitialized --- gtk/gtkmountoperation.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/gtk/gtkmountoperation.c b/gtk/gtkmountoperation.c index 6137388c0b..4a1c9f8a8b 100644 --- a/gtk/gtkmountoperation.c +++ b/gtk/gtkmountoperation.c @@ -981,21 +981,22 @@ update_process_list_store (GtkMountOperation *mount_operation, diff_sorted_arrays (current_pids, processes, pid_equal, pid_indices_to_add, pid_indices_to_remove); - if (pid_indices_to_add->len > 0) - lookup_context = _gtk_mount_operation_lookup_context_get (gtk_widget_get_display (mount_operation->priv->process_tree_view)); - for (n = 0; n < pid_indices_to_add->len; n++) - { - pid = g_array_index (processes, GPid, n); - add_pid_to_process_list_store (mount_operation, lookup_context, list_store, pid); - } - for (n = 0; n < pid_indices_to_remove->len; n++) { pid = g_array_index (current_pids, GPid, n); remove_pid_from_process_list_store (mount_operation, list_store, pid); } + if (pid_indices_to_add->len > 0) - _gtk_mount_operation_lookup_context_free (lookup_context); + { + lookup_context = _gtk_mount_operation_lookup_context_get (gtk_widget_get_display (mount_operation->priv->process_tree_view)); + for (n = 0; n < pid_indices_to_add->len; n++) + { + pid = g_array_index (processes, GPid, n); + add_pid_to_process_list_store (mount_operation, lookup_context, list_store, pid); + } + _gtk_mount_operation_lookup_context_free (lookup_context); + } /* select the first item, if we went from a zero to a non-zero amount of processes */ if (current_pids->len == 0 && pid_indices_to_add->len > 0) -- 2.30.2